[Form] Remove BC layer from ResizeFormListener
#60952
Merged
+8
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Jun 29, 2025
OskarStark
commented
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | -- |
| License | MIT |
OskarStark
force-pushed
the
remove-resizeformlistener-bc-layer
branch
from
54b564b to
237d06d
Compare
xabbuh
requested changes
Jun 30, 2025
Member
xabbuh
left a comment
xabbuh
left a comment
There was a problem hiding this comment.
The testPreSetDataResizesForm() test also needs to be removed (I wonder why the tests don't fail)
Contributor
Author
Done |
OskarStark
force-pushed
the
remove-resizeformlistener-bc-layer
branch
from
237d06d to
45281ac
Compare
Member
|
The "Verify Packages" failure also looks related. :) |
OskarStark
commented
Jun 30, 2025
src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php
Show resolved
Hide resolved
OskarStark
force-pushed
the
remove-resizeformlistener-bc-layer
branch
from
45281ac to
f8ddd36
Compare
Contributor
Author
Indeed, done, thanks |
stof
approved these changes
Jun 30, 2025
yceruto
approved these changes
Jun 30, 2025
OskarStark
force-pushed
the
remove-resizeformlistener-bc-layer
branch
from
f8ddd36 to
4afda18
Compare
OskarStark
commented
Jul 1, 2025
Contributor
Author
|
Rebased |
alexandre-daubois
approved these changes
Jul 2, 2025
fabpot
approved these changes
Jul 2, 2025
fabpot
force-pushed
the
remove-resizeformlistener-bc-layer
branch
from
5f042bf to
1812cfa
Compare
Member
|
Thank you @OskarStark. |
welcoMattic
added
the
BC Layer removal
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.