Skip to content

[TypeInfo] Fix PHPDoc resolving of union with mixed #59271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xabbuh merged 1 commit into from
Dec 27, 2024
Merged

[TypeInfo] Fix PHPDoc resolving of union with mixed #59271

xabbuh merged 1 commit into from
Dec 27, 2024

Conversation

@mtarld
Copy link
Contributor

@mtarld mtarld commented Dec 20, 2024 •
edited by xabbuh
Loading

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #59258, Fix #59223
License MIT

Resolve "invalid" union PHPDoc with mixed standalone type as mixed type.

@carsonbot carsonbot added this to the 7.3 milestone Dec 20, 2024
@carsonbot
Copy link

carsonbot commented Dec 20, 2024

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@mtarld mtarld changed the base branch from 7.3 to 7.2 December 20, 2024 11:27
This was referenced Dec 20, 2024
Closed
Closed
@xabbuh
Copy link
Member

xabbuh commented Dec 20, 2024

@mtarld FYI, I have added #59223 to the list of issues this PR is supposed to fix

Kocal
Kocal reviewed Dec 20, 2024
View reviewed changes
stof
stof reviewed Dec 20, 2024
View reviewed changes
@chalasr chalasr modified the milestones: 7.3, 7.2 Dec 24, 2024
@xabbuh
Copy link
Member

xabbuh commented Dec 27, 2024

Thank you @mtarld.

@xabbuh xabbuh merged commit 133ce8a into symfony:7.2 Dec 27, 2024
10 of 11 checks passed
@mtarld mtarld deleted the fix/union-mixed branch December 27, 2024 13:13
@fabpot fabpot mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof left review comments

@derrabus derrabus derrabus approved these changes

@xabbuh xabbuh xabbuh approved these changes

+1 more reviewer

@Kocal Kocal Kocal left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Status: Reviewed TypeInfo

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

[TypeInfo] Cannot create union with "mixed" standalone type.

7 participants

@mtarld @carsonbot @xabbuh @stof @derrabus @Kocal @chalasr