[DependencyInjection] Make #[AsTaggedItem] repeatable
#59088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
repeatable-as-tagged-item
branch
2 times, most recently
from
98b479c to
1d91ded
Compare
chalasr
reviewed
Dec 11, 2024
chalasr
approved these changes
Dec 11, 2024
alexandre-daubois
force-pushed
the
repeatable-as-tagged-item
branch
from
1d91ded to
34e3466
Compare
alexandre-daubois
changed the title
AsTaggedItem attribute repeatable#[AsTaggedItem] repeatable
alexandre-daubois
changed the title
#[AsTaggedItem] repeatable#[AsTaggedItem] repeatable
mtarld
approved these changes
Dec 11, 2024
OskarStark
approved these changes
Dec 11, 2024
fabpot
approved these changes
Jan 2, 2025
Member
|
Thank you @alexandre-daubois. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 5, 2025
… container builder (xabbuh) This PR was merged into the 7.3 branch. Discussion ---------- [DependencyInjection] reuse the reflector tracked by the container builder | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT reworking the implementation from #59088 a bit Commits ------- b8b5fb4 reuse the reflector tracked by the container builder
Merged
Member
|
I had a look at this code and the implementation doesn't make any sense sorry. This should be reverted, it's clumsy as it doesn't respect the flexibility provided by DI tags. |
Member
|
I agree with @nicolas-grekas. This implementation will read AsTaggedItem even when tag attributes are configured explicitly, which is not how this tag is meant to work. |
Member
Author
|
I'm working on a fix, it should be ready soon. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2025
…ggeditem] (nicolas-grekas) This PR was merged into the 7.3 branch. Discussion ---------- [DependencyInjection] Fix merging explicit tags and #[AsTaggeditem] | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #59088 (comment) | License | MIT Instead of #62327 Commits ------- e31b192 [DependencyInjection] Fix merging explicit tags and #[AsTaggeditem]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to repeat the
AsTaggedItemattribute: