make test case classes compatible with PHPUnit 10+ #58182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 5, 2024
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
xabbuh
requested review from
OskarStark,
chalasr and
welcoMattic
as code owners
stof
approved these changes
Sep 5, 2024
xabbuh
force-pushed
the
phpunit-test-case
branch
from
2be6c8c to
3ce98f1
Compare
xabbuh
force-pushed
the
phpunit-test-case
branch
from
3ce98f1 to
95a1efc
Compare
GromNaN
reviewed
Sep 5, 2024
Member
GromNaN
left a comment
GromNaN
left a comment
There was a problem hiding this comment.
Is it necessary to add stubs to the bridge to resolve the missing class errors reported by psalm?
Member
Author
|
I think we can ignore them. |
derrabus
approved these changes
Sep 5, 2024
Member
|
Currently we install PHPUnit 9.6 in our Psalm CI job. We might as well just bump that version. |
fabpot
approved these changes
Sep 6, 2024
Member
|
Thank you @xabbuh. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.