[String] [EnglishInflector] Fix words ending with le, e.g., articles
#57899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
changed the title
OskarStark
approved these changes
Aug 2, 2024
xabbuh
approved these changes
Aug 2, 2024
OskarStark
changed the title
le, e.g., articles
fabpot
approved these changes
Aug 3, 2024
Member
|
Thank you @aleho. |
This was referenced Aug 30, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The English inflector incorrectly singularizes words ending in "les", e.g., "articles":
As far as I'm aware "articl" is not a valid singular form for "articles". ;)
After this PR:
I'm not entirely sure whether the map entry is correct this way, but at least the tests don't break.