[Console] Test convert CompletionInput into string #57570
Conversation
| * | ||
| * @param string[] $tokens the set of split tokens (e.g. COMP_WORDS or argv) | ||
| * @param $currentIndex the index of the cursor (e.g. COMP_CWORD) | ||
| * @param int $currentIndex the index of the cursor (e.g. COMP_CWORD) |
There was a problem hiding this comment.
int is missing from this @param dockblock.
|
It's weird. I think the CI error might not be related to this test. Am I right? |
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
Failures unrelated indeed.
| yield ['bin/console cache:clear \'multi word string\'', ['bin/console', 'cache:clear', '\'multi word string\'']]; | ||
| } | ||
|
|
||
| public function testToString() |
There was a problem hiding this comment.
We could perhaps use a dataProvider for this test to avoid duplicating code ?
There was a problem hiding this comment.
Before adding this, I read ArgvInputTest and ArrayInputTest. There both don't use a dataProvider. Personally, I think use or not use dataProvider here is fine because there are only 2-3 cases.
If it's neccessary, I will implement. And we should implement for ArgvInputTest and ArrayInputTest too, shouldn't we?
There was a problem hiding this comment.
Oh no, it's not necessary, it's really just a matter of separating the test data from the test itself, but you're right, the code is simple and it's all detail.
|
Thank you @seriquynh. |
4 participants
CompletionInput can be converted into string but there are no tests for it. So, I a simple test here based on it's current behavior.