[Messenger] Add the --all option to the messenger:failed:remove command
#51593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
remove-all-failed-msgs
branch
from
9b7cbd9 to
0c6d6e1
Compare
kbond
approved these changes
Sep 15, 2023
fabpot
requested changes
Sep 16, 2023
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
remove-all-failed-msgs
branch
from
0c6d6e1 to
12d9ad0
Compare
Member
Author
|
All comments addressed, thanks! 🙂 |
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Tests/Command/FailedMessagesRemoveCommandTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Tests/Command/FailedMessagesRemoveCommandTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Tests/Command/FailedMessagesRemoveCommandTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Tests/Command/FailedMessagesRemoveCommandTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
remove-all-failed-msgs
branch
from
12d9ad0 to
dbed1a9
Compare
Member
Author
|
Addressed all your comments Nicolas, thank you! |
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
remove-all-failed-msgs
branch
2 times, most recently
from
f26d36b to
b674207
Compare
welcoMattic
reviewed
Sep 19, 2023
alexandre-daubois
force-pushed
the
remove-all-failed-msgs
branch
from
b674207 to
1ed3fea
Compare
src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
Outdated
Show resolved
Hide resolved
alexandre-daubois
force-pushed
the
remove-all-failed-msgs
branch
2 times, most recently
from
7d62d21 to
322d892
Compare
nicolas-grekas
force-pushed
the
remove-all-failed-msgs
branch
from
322d892 to
d1d39c0
Compare
nicolas-grekas
approved these changes
Sep 29, 2023
Member
|
Thank you @alexandre-daubois. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a development server (which we don't have direct access to the database). As this server serves as a test for our devs, error messages can accumulate in our failure transport. We wanted to use the
messenger:failed:removecommand to remove them, but unfortunately, we must provide ids individually. This is problematic as we have several hundreds of failed messages.This PR adds the
--alloption to the command. This option must be used with the--forceoption (juste likedoctrine:schema:update --forceactually) to work. Example output:$ bin/console messenger:failed:remove --all --force ... Failed Message Details ====================== [WARNING] Message does not appear to have been sent to this transport after failing ------------ ------------------------- Class App\Message\YourMessage Message Id 6 ------------ ------------------------- ! [NOTE] 4 messages were removed.As you can see, you can of course still use the
--show-messagesoption jointly.