[HttpKernel] Support backed enums in #[MapQueryParameter]
#51004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
andersmateusz
force-pushed
the
feature/map-query-param-backed-enum
branch
from
7f2cc82 to
3a10b7f
Compare
andersmateusz
force-pushed
the
feature/map-query-param-backed-enum
branch
5 times, most recently
from
4a5479e to
8625bc4
Compare
nicolas-grekas
force-pushed
the
feature/map-query-param-backed-enum
branch
3 times, most recently
from
f3c785d to
d05390c
Compare
nicolas-grekas
approved these changes
Jul 20, 2023
nicolas-grekas
force-pushed
the
feature/map-query-param-backed-enum
branch
from
d05390c to
a201df7
Compare
maxbeckers
approved these changes
Jul 20, 2023
andersmateusz
commented
Jul 20, 2023
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php
Outdated
Show resolved
Hide resolved
andersmateusz
force-pushed
the
feature/map-query-param-backed-enum
branch
from
a201df7 to
487f5f8
Compare
kells64000
reviewed
Jul 28, 2023
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/QueryParameterValueResolver.php
Show resolved
Hide resolved
OskarStark
changed the title
#[MapQueryParameter]
nicolas-grekas
approved these changes
Aug 2, 2023
fabpot
approved these changes
Aug 3, 2023
Member
|
Thank you @andersmateusz. |
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had two options to introduce this feature. Extending
QueryParameterValueResolveror extendingBackedEnumValueResolver. Both options have it's prons and cons. ExtendingQueryParameterValueResolveris not consistent with DRY principle, but on the other hand does not mislead users about usage ofValueResolverInterface(#[MapQueryParameter]takesresolverargument but onlyQueryParameterValueResolverresolves value unless creating your own implementation of the interface). I have chosen to extendQueryParameterValueResolver. I think in the future separation of concerns should be introduced (resolving query params, resolving attributes etc.). For example by typing resolvers with new interface and using intersection types.