-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Runtime] Allow JSON for APP_RUNTIME_OPTIONS #45535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is not a bugfix ;) |
nicolas-grekas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about making SymfonyRuntime's constructor accept array|json-string instead?
Not a good idea as that would prevent merging with options generated by the plugin!
src/Symfony/Component/Runtime/Internal/autoload_runtime.template
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Runtime/Internal/autoload_runtime.template
Outdated
Show resolved
Hide resolved
Are you saying APP_RUNTIME_OPTIONS is not a supported env var? but more like some internal global var? IMHO it looks like an env var extension point ... thus should support string values actually. Thus a bugfix :) Or how could i set an PHP array using env var? We're not at 6.1 yet, so as a feature i will postpone this PR. And we patch the front controller manually for the time being (maybe forever), if that's the intended feature-usage currently. |
|
So, tbe bugfix would be |
yes, that's been the intent so far, not reading from env. |
|
then, what about renaming it to |
|
I don't see why, better not to me 🤷 |
|
Can you add a test case? |
|
I'll continue this with our php8/sf6 upgrade 👍 |
So we can export
APP_RUNTIME_OPTIONS='{"disable_dotenv":true}'in prod