[Notifier] Add FakeChat Logger transport #42188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noniagriconomie
commented
Jul 19, 2021
src/Symfony/Component/Notifier/Bridge/FakeChat/Tests/FakeChatLoggerTransportTest.php
Show resolved
Hide resolved
OskarStark
approved these changes
Jul 19, 2021
OskarStark
reviewed
Jul 19, 2021
src/Symfony/Component/Notifier/Bridge/FakeChat/Tests/FakeChatLoggerTransportTest.php
Outdated
Show resolved
Hide resolved
noniagriconomie
changed the title
Contributor
|
Please extend |
noniagriconomie
changed the title
noniagriconomie
force-pushed
the
ft-40625-2
branch
3 times, most recently
from
cca2045 to
d43645e
Compare
noniagriconomie
changed the title
noniagriconomie
force-pushed
the
ft-40625-2
branch
from
d43645e to
b76a382
Compare
OskarStark
reviewed
Jul 19, 2021
src/Symfony/Component/Notifier/Bridge/FakeChat/Tests/TestLogger.php
Outdated
Show resolved
Hide resolved
noniagriconomie
force-pushed
the
ft-40625-2
branch
from
b76a382 to
67b85f7
Compare
carsonbot
changed the title
carsonbot
changed the title
derrabus
requested changes
Aug 1, 2021
Member
derrabus
left a comment
derrabus
left a comment
There was a problem hiding this comment.
Can you have a look at the Psalm errors?
OskarStark
reviewed
Aug 1, 2021
src/Symfony/Component/Notifier/Bridge/FakeChat/FakeChatTransportFactory.php
Show resolved
Hide resolved
noniagriconomie
force-pushed
the
ft-40625-2
branch
from
67b85f7 to
ca924a9
Compare
noniagriconomie
force-pushed
the
ft-40625-2
branch
from
ca924a9 to
2bfe06f
Compare
Contributor
Author
|
friendly ping @OskarStark @derrabus code reworked as requested, thx |
OskarStark
approved these changes
Aug 4, 2021
derrabus
approved these changes
Aug 4, 2021
Contributor
|
Thanks Antoine. |
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Aug 7, 2021
…iconomie) This PR was merged into the 5.4 branch. Discussion ---------- [Notifier] Document fake chat logger notifier Document symfony/symfony#42188 (no issue created post merge) Follows #15595 Commits ------- 4e5845b Document fake chat logger notifier
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #42123 for Notifier FakeChat