[Serializer] Remove deprecation layer #41657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
derrabus
commented
Jun 10, 2021
derrabus
commented
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | N/A |
| License | MIT |
| Doc PR | N/A |
derrabus
force-pushed
the
remove/serializer-deprecations
branch
from
b608c8e to
40042a6
Compare
|
Hey! I think @xfifix has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
derrabus
force-pushed
the
remove/serializer-deprecations
branch
from
40042a6 to
f6a01e8
Compare
derrabus
force-pushed
the
remove/serializer-deprecations
branch
from
f6a01e8 to
222ea81
Compare
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
please rebase so that we can see green tests :)
derrabus
force-pushed
the
remove/serializer-deprecations
branch
from
222ea81 to
42061be
Compare
Member
Author
|
Fabbot failure is the usual false positive, AppVeyor failure is unrelated. The remaining tests are green. |
OskarStark
reviewed
Jun 30, 2021
| } | ||
| } | ||
|
|
||
| public function __construct( |
Member
There was a problem hiding this comment.
when using constructor property promotion, I think we should use several lines actually
we do so already for attributes
| throw new \TypeError(sprintf('"%s": Argument $typeProperty was expected to be a string or array, got "%s".', __METHOD__, get_debug_type($typeProperty))); | ||
| } | ||
|
|
||
| public function __construct( |
Signed-off-by: Alexander M. Turek <[email protected]>
nicolas-grekas
force-pushed
the
remove/serializer-deprecations
branch
from
42061be to
56034b5
Compare
Member
|
Thank you @derrabus. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.