Skip to content

[HttpKernel] Deprecate returning a ContainerBuilder from KernelInterface::registerContainerConfiguration() #40432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chalasr merged 1 commit into from
Mar 10, 2021
Merged

[HttpKernel] Deprecate returning a ContainerBuilder from KernelInterface::registerContainerConfiguration() #40432

chalasr merged 1 commit into from
Mar 10, 2021

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Mar 10, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? yes
Tickets -
License MIT
Doc PR -

This behavior was introduced in 38aef98#diff-7753dd9020accbf6eb7c3dbb86a992340ce9dff4a0258458d7bbdd0a3d396939R261

But this is never used nor tested AFAIK, and the interface doesn't document it.

@nicolas-grekas nicolas-grekas added this to the 5.x milestone Mar 10, 2021
@stof
Copy link
Member

stof commented Mar 10, 2021 •
edited
Loading

this was not introduced in #7437. The code was already there before. This PR only moved it.

Supporting returning a ContainerBuilder was actually a BC layer for code written before 2.0.0-PR3 (see dcaf436). So 👍 for finally cleaning that.

@chalasr
Copy link
Member

chalasr commented Mar 10, 2021

Thank you @nicolas-grekas.

@chalasr chalasr merged commit fe23c88 into symfony:5.x Mar 10, 2021
@chalasr chalasr mentioned this pull request Mar 10, 2021
Closed
@nicolas-grekas nicolas-grekas deleted the hk-reg branch March 16, 2021 19:18
@fabpot fabpot mentioned this pull request Apr 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derrabus derrabus derrabus approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

No one assigned

Labels

Deprecation HttpKernel Status: Reviewed

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas @stof @chalasr @derrabus @carsonbot