[DI] Add AutowireRequiredMethodsPass to fix bindings for @required methods
#24301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Sep 23, 2017
| $this->assertEquals(array(new Reference('foo')), $container->getDefinition('def2')->getArguments()); | ||
| } | ||
|
|
||
| public function testScalarSetter() |
Member
Author
There was a problem hiding this comment.
Here is the test that backs up the fixed behavior.
nicolas-grekas
commented
Sep 23, 2017
| // should be called | ||
| } | ||
|
|
||
| /** @inheritdoc*/ |
Member
Author
There was a problem hiding this comment.
this fabbot failure is expected
ogizanagi
approved these changes
Sep 24, 2017
Contributor
ogizanagi
left a comment
ogizanagi
left a comment
There was a problem hiding this comment.
Perhaps AutowireRequiredMethodsPass would be more explicit.
nicolas-grekas
force-pushed
the
autoregister-methods
branch
from
8bb946a to
a9afeea
Compare
Member
Author
|
@ogizanagi renamed, thanks |
nicolas-grekas
force-pushed
the
autoregister-methods
branch
from
a9afeea to
c7afcf6
Compare
weaverryan
reviewed
Sep 24, 2017
| return $value; | ||
| } | ||
|
|
||
| $autowiredMethods = $this->getMethodsToAutowire($reflectionClass); |
Member
There was a problem hiding this comment.
The getMethodsToAutowire still exists in this class, can be removed now
Member
Author
There was a problem hiding this comment.
indeed, done, thanks
nicolas-grekas
force-pushed
the
autoregister-methods
branch
from
c7afcf6 to
aa2b76b
Compare
nicolas-grekas
changed the title
@required methods@required methods
nicolas-grekas
force-pushed
the
autoregister-methods
branch
from
aa2b76b to
dc55dd2
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Sep 25, 2017
…or `@required` methods (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Add AutowireRequiredMethodsPass to fix bindings for `@required` methods | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted while doing a SF4 workshop :) Discovery of `@required` methods should be split from AutowirePass so that bindings can apply to these methods also when autowiring is enabled. Commits ------- dc55dd2 [DI] Add AutowireRequiredMethodsPass to fix bindings for `@required` methods
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while doing a SF4 workshop :)
Discovery of
@requiredmethods should be split from AutowirePass so that bindings can apply to these methods also when autowiring is enabled.