[FrameworkBundle][HttpKernel] Move httpkernel pass #22620
Conversation
chalasr
left a comment
chalasr
left a comment
There was a problem hiding this comment.
AddCacheWarmerPassTest should be marked as legacy and copied to the component.
Also deprecations are missing (@trigger_error(...)
| */ | ||
| public function process(ContainerBuilder $container) | ||
| { | ||
| if (!$container->hasDefinition('cache_clearer')) { |
There was a problem hiding this comment.
same as for your other PR, target service id + collected tag name should be configurable through the constructor, defaulting to the ones used in frameworkbundle.
| * @author Dustin Dobervich <[email protected]> | ||
| */ | ||
| class AddCacheClearerPass implements CompilerPassInterface | ||
| class AddCacheClearerPass extends BaseAddCacheClearerPass |
| * @author Fabien Potencier <[email protected]> | ||
| */ | ||
| class AddCacheWarmerPass implements CompilerPassInterface | ||
| class AddCacheWarmerPass extends BaseAddCacheWarmerPass |
lepiaf
changed the title
|
@lepiaf The 3.4 branch has been created and is the one that this PR should target (changing the based branch and rebase). |
|
You should also rebase instead of merging. |
| }, | ||
| "conflict": { | ||
| "symfony/config": "<2.8", | ||
| "symfony/dependency-injection": "<3.3", |
There was a problem hiding this comment.
the changes on this file should be reverted. You need DI 3.3+ only
|
This makes tests fail for now. |
|
@chalasr sure, I will do it now |
| use PriorityTaggedServiceTrait; | ||
|
|
||
| private $cacheWarmerId; | ||
| private $kernelCacheWarmerId; |
| class AddCacheClearerPass implements CompilerPassInterface | ||
| { | ||
| private $cacheClearerId; | ||
| private $kernelCacheClearerId; |
| $container->addCompilerPass(new LoggingTranslatorPass()); | ||
| $container->addCompilerPass(new AddCacheWarmerPass()); | ||
| $container->addCompilerPass(new AddCacheClearerPass()); | ||
| $this->addCompilerPassIfExists($container, AddCacheWarmerPass::class); |
There was a problem hiding this comment.
No need for using addCompilerPassIfExists() because http-kernel is an hard dependency, addCompilerPass() should be used directly, that will make the build failure more clear also (fail on unexisting class until merged up to master)
|
Thank you @lepiaf. |
…piaf) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][HttpKernel] Move httpkernel pass | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | part of #21284 | License | MIT | Doc PR | n/a Move addcachearmer, addcacheclearer compiler pass to httpkernel Commits ------- 83727c7 [FrameworkBundle][HttpKernel] Move addcachearmer, addcacheclearer compiler pass
6 participants
Move addcachearmer, addcacheclearer compiler pass to httpkernel