[HttpFoundation] Do not overwrite the Authorization header if it is already set #17478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
Jan 21, 2016
jakzal
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #17345 |
| License | MIT |
| Doc PR | - |
Contributor
|
This bug AFAIK exists on 2.3+ so it should be merged in lowest branch not highest. |
Contributor
Author
|
@stloyd yes, it should be merged on 2.3. That's what I based my branch on. I selected the wrong target branch when sending the PR :) |
Member
|
👍 |
Member
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
Jan 22, 2016
… if it is already set (jakzal) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #17478). Discussion ---------- [HttpFoundation] Do not overwrite the Authorization header if it is already set | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17345 | License | MIT | Doc PR | - Commits ------- 53ebfda [HttpFoundation] Do not overwrite the Authorization header if it is already set
Merged
This was referenced Feb 28, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.