feat: otel metrics #819
Merged
feat: otel metrics #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 21515862680Details
💛 - Coveralls |
fenos
force-pushed
the
monitoring/otel-metrics
branch
from
ddcc147 to
c9d5fd0
Compare
itslenny
approved these changes
Jan 8, 2026
ferhatelmas
reviewed
Jan 12, 2026
Comment on lines
+605
to
+617
| { | ||
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "local_prometheus" | ||
| }, | ||
| "editorMode": "code", | ||
| "expr": "sum(increase(storage_api_otel_upload_started_total{region=~\"$region\", instance=~\"$instance\"}[$__range]))", | ||
| "hide": false, | ||
| "instant": false, | ||
| "legendFormat": "__auto", | ||
| "range": true, | ||
| "refId": "C" | ||
| } |
There was a problem hiding this comment.
This was supposed to be multipart I guess according to description but instead duplicates query A
ferhatelmas
reviewed
Jan 12, 2026
ferhatelmas
reviewed
Jan 13, 2026
| hostMetrics.start() | ||
|
|
||
| // Register Node.js runtime instrumentations | ||
| registerInstrumentations({ |
There was a problem hiding this comment.
I think we need to capture returned function unregister here to pass shutdown below. Otherwise, it might prevent process from exiting
Contributor
Author
There was a problem hiding this comment.
Thanks! I have double checked but this function is not returning anything.
I guess it registers it internally, and on stop, it will clean it up
There was a problem hiding this comment.
It returns a cleanup function, I believe we need to call it before meter shutdown for clean exit because it will stop timer for metric reader but won't touch the timer inside custom instrument. Another approach could be making timer unblocking as in #819 (comment)
ferhatelmas
reviewed
Jan 13, 2026
ferhatelmas
reviewed
Jan 13, 2026
fenos
force-pushed
the
monitoring/otel-metrics
branch
4 times, most recently
from
c85a64a to
6bd7d5a
Compare
fenos
force-pushed
the
monitoring/otel-metrics
branch
from
6bd7d5a to
2a88ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Currently metrics are gathered using the prom-client and exposed to a metric endpoint
What is the new behavior?
ENABLE_PROMETHEUS_METRICS)Grafana dashboard
Running completely locally