fix(migrations): case-sensitive migration rollback detection#3919
Merged
kyleconroy merged 1 commit intosqlc-dev:mainfrom Apr 11, 2025
Merged
Conversation
dosubot
bot
added
the
size:XS
FadyGamilH
approved these changes
Apr 3, 2025
Collaborator
|
@0xSherlokMo appreciate the simple change and the excellent explanation. |
alfonsodev
pushed a commit
to ExponentiaTeam/sqlc
that referenced
this pull request
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where SQLC was failing to properly detect and remove rollback statements in migration files due to case sensitivity. Previously, SQLC only recognized uppercase
Downin rollback statements (e.g.,-- +goose Down), but migration tools like Goose have updated their documentation to use lowercasedown(e.g.,-- +goose down).The change makes the rollback statement detection case-insensitive by converting the statement to lowercase before checking, ensuring compatibility with:
-- +goose Downand-- +goose down(Goose migrations)-- +migrate Downand-- +migrate down(sql-migrate)This maintains backward compatibility with existing migrations while supporting the current documentation standards of migration tools.
Fixes issue #3444
Changes
RemoveRollbackStatementsto perform case-insensitive comparison by converting statements to lowercase before checkingTesting