examples: Add missing Close calls#3828
Merged
kyleconroy merged 2 commits intosqlc-dev:mainfrom Feb 7, 2025
alexandear:fix-add-missing-close
Merged
examples: Add missing Close calls#3828kyleconroy merged 2 commits intosqlc-dev:mainfrom alexandear:fix-add-missing-close
kyleconroy merged 2 commits intosqlc-dev:mainfrom
alexandear:fix-add-missing-close
Conversation
dosubot
bot
added
the
size:S
dosubot
bot
added
size:XS
Collaborator
|
Thanks! |
alfonsodev
pushed a commit
to ExponentiaTeam/sqlc
that referenced
this pull request
Oct 13, 2025
* examples: Add missing Close calls * Update db_test.go --------- Co-authored-by: Kyle Gray <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes
sqltest.SQLiteusages and implementation by adding the missingsdb.Close()andsource.Close().sqltest.SQLitereturns*sql.DB, which we need to close as shown here:sqlc/internal/endtoend/vet_test.go
Lines 57 to 59 in 9cf5dbc
os.CreateTempcreates a new temporary file in the directorydir, opens the file for reading and writing, and returns the resulting file. We also need to close it.