Keep environment variables on calling plugin#2661
Closed
walterwanderley wants to merge 1 commit intosqlc-dev:mainfrom
Closed
Keep environment variables on calling plugin#2661walterwanderley wants to merge 1 commit intosqlc-dev:mainfrom
walterwanderley wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
Collaborator
|
We intentionally limit the environment variables sent to process-based plugins to ensure that those plugins can't easily steal credentials stored in the environment. I'm happy to add an allowlist of variables though and include just those. Which environment variables does your plugin need access to? |
Author
|
Ok, Just need the PATH env. |
Collaborator
|
Merged the other PR, will be available in the next release :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to convert https://github.com/walterwanderley/sqlc-grpc into a plugin