>=2 objects in eq and parallel constraints#530
Closed
77maxikov wants to merge 1 commit intosolvespace:masterfrom
Closed
>=2 objects in eq and parallel constraints#53077maxikov wants to merge 1 commit intosolvespace:masterfrom
77maxikov wants to merge 1 commit intosolvespace:masterfrom
Conversation
whitequark
suggested changes
May 2, 2020
Contributor
whitequark
left a comment
whitequark
left a comment
There was a problem hiding this comment.
The PR implements the feature in an ad-hoc and invasive way; I find it hard to convince myself that every added code path is correct. It doesn't follow our code style either.
Contributor
phkahler
force-pushed
the
master
branch
2 times, most recently
from
dfb96de to
3f09eaf
Compare
17 tasks
Member
|
After looking at this problem a lot, I believe this is the way. @77maxikov if you rebase this to master I'll merge it and then build on it a little. I'll probably do it myself this weekend if nobody else does - I'm getting the itch to work on solvespace again! |
Contributor
Author
Member
|
Closing since 1314 was used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.