Modify GNU thumbnailer #1674
Open
Modify GNU thumbnailer #1674
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I've been thinking about this thumbnailer stuff and I don't think we want it by default for builds - only for "make install" and then preferably as an option. I still think it's more of a packaging thing. I just don't like the idea of saving a file from email or off the internet and having software open it by default. @ruevs what do you think? |
Member
|
This is quite far from my daily computer use since I do not use (desktop) Linux regularly. But it definitely sounds like a distro/packaging problem. Whether the default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edit aligns the thumbnailer feature with PR #1673. Specifically, it modifies the solvespace.thumbnail file to point to the installed executable. This means that if a user installs solvespace to ~/.local, the thumbnailer will work for that user.
This is necessary because ~/.local/bin is not normally included in the default PATH environment variable.