Skip to content

When extruding a line to face, use a point in new group for the face.… #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phkahler merged 1 commit into from
Feb 4, 2026
+771 −827
Merged

When extruding a line to face, use a point in new group for the face.… #1671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/group.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,8 +899,8 @@ void Group::MakeExtrusionLines(EntityList *el, hEntity in) {
en.param[1] = h.param(1);
en.param[2] = h.param(2);
en.numPoint = a;
// we need a point somewhere on the face. Use one from the original line.
en.point[0] = ep->point[0];
// we need a point somewhere on the face, and it must be from the current group.
en.point[0] = Remap(ep->point[0], REMAP_TOP);
en.numNormal = Quaternion::From(0, ab.x, ab.y, ab.z);

en.group = h;
Expand Down
32 changes: 12 additions & 20 deletions test/group/translate_asy/normal.slvs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,6 @@ Group.remap={
127 8003002b 1000
128 8003002c 1000
129 8003002d 1000
130 00040001 0
131 00050001 0
132 00060001 0
133 00070001 0
134 00040001 1000
135 00050001 1000
136 00060001 1000
137 00070001 1000
}
AddGroup

Expand Down Expand Up @@ -729,7 +721,7 @@ AddEntity
Entity.h.v=80030007
Entity.type=5001
Entity.construction=0
Entity.point[0].v=00040001
Entity.point[0].v=80030005
Entity.actPoint.x=10.00000000000000000000
Entity.actPoint.y=-5.00000000000000000000
Entity.actNormal.vx=-1.00000000000000000000
Expand Down Expand Up @@ -805,7 +797,7 @@ AddEntity
Entity.h.v=80030010
Entity.type=5001
Entity.construction=0
Entity.point[0].v=00050001
Entity.point[0].v=8003000e
Entity.actPoint.x=-5.00000000000000000000
Entity.actPoint.y=-5.00000000000000000000
Entity.actNormal.vy=1.00000000000000000000
Expand Down Expand Up @@ -881,7 +873,7 @@ AddEntity
Entity.h.v=80030019
Entity.type=5001
Entity.construction=0
Entity.point[0].v=00060001
Entity.point[0].v=80030017
Entity.actPoint.x=-5.00000000000000000000
Entity.actPoint.y=5.00000000000000000000
Entity.actNormal.vx=1.00000000000000000000
Expand Down Expand Up @@ -957,7 +949,7 @@ AddEntity
Entity.h.v=80030022
Entity.type=5001
Entity.construction=0
Entity.point[0].v=00070001
Entity.point[0].v=80030020
Entity.actPoint.x=10.00000000000000000000
Entity.actPoint.y=5.00000000000000000000
Entity.actNormal.vy=-1.00000000000000000000
Expand Down Expand Up @@ -1087,7 +1079,7 @@ AddEntity
Entity.h.v=80040007
Entity.type=5003
Entity.construction=0
Entity.point[0].v=80040082
Entity.point[0].v=80040005
Entity.actPoint.x=10.00000000000000000000
Entity.actPoint.y=-5.00000000000000000000
Entity.actNormal.vx=-1.00000000000000000000
Expand Down Expand Up @@ -1163,7 +1155,7 @@ AddEntity
Entity.h.v=80040010
Entity.type=5003
Entity.construction=0
Entity.point[0].v=80040083
Entity.point[0].v=8004000e
Entity.actPoint.x=-5.00000000000000000000
Entity.actPoint.y=-5.00000000000000000000
Entity.actNormal.vy=1.00000000000000000000
Expand Down Expand Up @@ -1239,7 +1231,7 @@ AddEntity
Entity.h.v=80040019
Entity.type=5003
Entity.construction=0
Entity.point[0].v=80040084
Entity.point[0].v=80040017
Entity.actPoint.x=-5.00000000000000000000
Entity.actPoint.y=5.00000000000000000000
Entity.actNormal.vx=1.00000000000000000000
Expand Down Expand Up @@ -1315,7 +1307,7 @@ AddEntity
Entity.h.v=80040022
Entity.type=5003
Entity.construction=0
Entity.point[0].v=80040085
Entity.point[0].v=80040020
Entity.actPoint.x=10.00000000000000000000
Entity.actPoint.y=5.00000000000000000000
Entity.actNormal.vy=-1.00000000000000000000
Expand Down Expand Up @@ -1445,7 +1437,7 @@ AddEntity
Entity.h.v=8004005d
Entity.type=5003
Entity.construction=0
Entity.point[0].v=80040086
Entity.point[0].v=8004005b
Entity.actPoint.x=20.00000000000000000000
Entity.actPoint.z=-5.00000000000000000000
Entity.actNormal.vx=-1.00000000000000000000
Expand Down Expand Up @@ -1519,7 +1511,7 @@ AddEntity
Entity.h.v=80040066
Entity.type=5003
Entity.construction=0
Entity.point[0].v=80040087
Entity.point[0].v=80040064
Entity.actPoint.x=5.00000000000000000000
Entity.actPoint.z=-5.00000000000000000000
Entity.actNormal.vy=1.00000000000000000000
Expand Down Expand Up @@ -1595,7 +1587,7 @@ AddEntity
Entity.h.v=8004006f
Entity.type=5003
Entity.construction=0
Entity.point[0].v=80040088
Entity.point[0].v=8004006d
Entity.actPoint.x=5.00000000000000000000
Entity.actPoint.y=10.00000000000000000000
Entity.actPoint.z=-5.00000000000000000000
Expand Down Expand Up @@ -1674,7 +1666,7 @@ AddEntity
Entity.h.v=80040078
Entity.type=5003
Entity.construction=0
Entity.point[0].v=80040089
Entity.point[0].v=80040076
Entity.actPoint.x=20.00000000000000000000
Entity.actPoint.y=10.00000000000000000000
Entity.actPoint.z=-5.00000000000000000000
Expand Down
Loading