When extruding a line to face, use a point in new group for the face.…#1671
Open
phkahler wants to merge 1 commit intosolvespace:masterfrom
Open
When extruding a line to face, use a point in new group for the face.…#1671phkahler wants to merge 1 commit intosolvespace:masterfrom
phkahler wants to merge 1 commit intosolvespace:masterfrom
Conversation
Member
Member
Author
Thanks, I will. It was a hasty decision to use the original point for line-face extrusion. Turns out it's really a bad idea for an entity to use a point from a previous group. If the face in question is copied (step translate/rotate) that point will not be copied into the new repeat group, but the copied faces will try to reference the remapped point which does not exist. Or something like that. It will also add invalid entries to the remap table when the face tries to reference Ramap(my point, number). |
Member
|
The good thing is we have users using edge builds or compiling and they caught it :-) I regret not thinking more last time... it was just a hunch but I could not immediately rationalize it... |
… Using one from the previous group causes subsequent translate groups to have undraggable faces and possibly other problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… Using one from the previous group causes subsequent translate groups to have undraggable faces and possibly other problems.