Skip to content

feat(isr): add compression #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maxisam wants to merge 23 commits into from
Closed

feat(isr): add compression #1763

maxisam wants to merge 23 commits into from

Conversation

@maxisam
Copy link
Contributor

@maxisam maxisam commented Aug 30, 2024

#1755

  • update type of express, to work with express compress
  • add two more options
    • compressHtml: compression callback to compress the html before storing it in the cache.
    • htmlCompressionMethod: html compression method, it will use gzip by default if not provided.
  • with compressHtml handler, it will automatically disable modifyCachedHtml, since cached html is btye after compressed.

This needs to wait until other PR #1760 #1757 get merged

maxisam added 23 commits August 20, 2024 14:47
@maxisam
chore(isr): update CacheHandler and IsrServiceInterface typings
ba1cbbe
@maxisam
refactor: fix eslint issues
f7755ac
@maxisam
fix(isr): filter urlsOnHold by cacheKey instead of url
0af4f56
@maxisam
feat: add allowed query params options rx-angular#1743
244bff7
@maxisam
feat: handle query string for filesystem cache rx-angular#1690
50643b3
@maxisam
fix(isr): in memory cache handler should use extends rx-angular#1736
9dc5a70
@maxisam
Merge branch 'fix/instanceof' into dev
76aa916
@maxisam
Merge branch 'refactor/es-lint' into dev
fcb59b2
@maxisam
Merge branch 'feat/allowed-query-params' into dev
cc19ee3
@maxisam
refactor(isr): rename CacheRegeneration to CacheGeneration
c37269b
@maxisam
refactor(isr): rename CacheRegeneration to CacheGeneration
039f09c
@maxisam
fix(isr): handle modifyGeneratedHtml behavior consistantly rx-angular…
c95d1c6 
…#1758
@maxisam
Merge branch 'main' into dev
e7ed6a5
@maxisam
refactor(isr): use modifyGeneratedHtml instead
cb0261a
@maxisam
feat(isr): update the example to show modifyGeneratedHtml usage
2dd9551
@maxisam
Merge branch 'main' into feat/callback-cachemsg
9f4f0cd
@maxisam
Merge pull request #2 from maxisam/feat/consolidate-cache-generation
5b7603e 
Feat: consolidate cache generation
@maxisam
feat(isr): add non-blocking-render option
2c88c4f
@maxisam
feat(isr): add background revalidation option
dcc61f9
@maxisam
feat(isr): enable background revalidation and non-blocking render
fe0bac2
@maxisam
Merge pull request #3 from maxisam/feat/response-first
a88b5ca 
feat(isr): nonBlockingRender & backgroundRevalidation
@maxisam
feat(isr): add compression rx-angular#1755
2ae8857
@maxisam
chore(isr): rename HTML compression method
85b0dc3
@github-actions github-actions bot added 📚 Docs Web Documentation hosted on github pages 🚀 ISR labels Aug 30, 2024
@nx-cloud
Copy link

nx-cloud bot commented Aug 30, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 85b0dc3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@eneajaho
Copy link
Member

eneajaho commented Sep 1, 2024

Hello @maxisam
Can you create another PR to only include compression commits? All the previous PRs are already merged so you can just cherry pick the commits I guess.

Also, I was thinking to compress the result after we modify the HTML, and then store in cache.

-> Render
-> Modify Html
-> Compress
-> Store in cache

This way we don't break anything.

@maxisam
Copy link
Contributor Author

maxisam commented Sep 2, 2024 •
edited
Loading

yes, I can do that. I thought I render HTML first and modify and compress after currently. I need to double check it when I get back

@maxisam maxisam closed this Sep 3, 2024
@maxisam
Copy link
Contributor Author

maxisam commented Sep 3, 2024

#1768 use this one instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

📚 Docs Web Documentation hosted on github pages 🚀 ISR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxisam @eneajaho