Skip to content

Conversation

@yalcantara
Copy link

No description provided.

@yalcantara yalcantara changed the title (Draft)WS-2589: removing genre from doc & future print_function WS-2589: removing genre from doc & future print_function Nov 10, 2022
@seth-mg seth-mg self-requested a review November 14, 2022 17:37
Copy link
Contributor

@seth-mg seth-mg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yalcantara two comments on the PR.
1.) The name_similarity.py example still uses the original print.
2.) There are two references to genre in rosette/api.py that need attention.

@yalcantara
Copy link
Author

@yalcantara two comments on the PR.
1.) The name_similarity.py example still uses the original print.
2.) There are two references to genre in rosette/api.py that need attention.

The name_similarity.py is now fixed ^_^. And the references in api.py is removed since it isn't for entities (might be a copy/paste mistake).

Copy link
Contributor

@seth-mg seth-mg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-mg seth-mg merged commit 0ab6df0 into develop Nov 17, 2022
@seth-mg seth-mg deleted the WS-2589-remove-genre-from-entities-example branch November 17, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants