Skip to content

fix failing dump command#276

Merged
gabor-boros merged 1 commit intorethinkdb:masterfrom
besworks:master
May 12, 2022
Merged

fix failing dump command#276
gabor-boros merged 1 commit intorethinkdb:masterfrom
besworks:master

Conversation

@besworks
Copy link
Contributor

@besworks besworks commented May 11, 2022

Reason for the change

Per Issue #225

File ".../rethinkdb/utils_common.py", line 311, in take_action
values[dest] = getpass.getpass("Password for admin: ")
TypeError: 'Values' object does not support item assignment

Description
The values object is an instance of optparse_parser.Values which, as the error message states, does not support item assignment. I modified the option checker to use the ensure_value method of the values object to set the password.

Checklist

@gabor-boros gabor-boros linked an issue May 11, 2022 that may be closed by this pull request
dump failed with v2.4.7 #225
Closed
@gabor-boros
Copy link
Member

gabor-boros commented May 11, 2022 •
edited
Loading

@besworks Thank you for the fix 🎉

This looks good to me! I'll merge this later today and cut a new release on Pypi.

@gabor-boros
Copy link
Member

gabor-boros commented May 11, 2022 •
edited
Loading

Although I could do the release now, I prefer doing it with fresh eyes. So I'll do it tomorrow morning as a first step after my coffee.

Sorry about any inconviniences.

@gabor-boros gabor-boros merged commit bc1a75a into rethinkdb:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabor-boros gabor-boros gabor-boros approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dump failed with v2.4.7

2 participants

@besworks @gabor-boros