Add browser integration tests using Playwright#222
Merged
Conversation
aron
commented
Mar 13, 2024
aron
force-pushed
the
browser-integration
branch
5 times, most recently
from
4d5591d to
5c2fd05
Compare
Browsers don't yet support async iteration of ReadableStream so we need to do this manually
aron
force-pushed
the
browser-integration
branch
4 times, most recently
from
35fc764 to
9949342
Compare
aron
force-pushed
the
browser-integration
branch
from
9949342 to
866f852
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently just tests the streaming API on Chromium but it caught a bug with
ReadableStream. I know we don't officially support the browser environments yet, but I do think we should ensure that it works if possible.It's relatively simple to setup a CloudFlare worker, for example, that applies the API token + CORS headers to a browser request for example should someone want to do such a thing.