Closed
Conversation
clue
reviewed
Feb 4, 2022
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@danielmadu Thank you for looking into this!
ReactPHP's components do indeed support PHP 8+ just fine, so it makes perfect sense to also add this to the CI setup for this meta repository.
Your PR test run currently fails because this meta repository hasn't been updated to the latest PHPUnit version yet and as such doesn't support testing on PHP 8. I've prepared a PR to update to PHPUnit 9 that I'll be able to file once #449 is in. Once the PHPUnit PR is in, we can rebase your PR on the current master and get this in! 
This was referenced Feb 6, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.