Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,12 @@ You can install or upgrade ``python-telegram-bot`` via

.. code:: shell

#Requires Python 3.10+.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having this as comment in the shell, I suggest moving it up to line 100, i.e. … ptb on Python 3.10+ via …

$ pip install python-telegram-bot --upgrade

To install a pre-release, use the ``--pre`` `flag <https://pip.pypa.io/en/stable/cli/pip_install/#cmdoption-pre>`_ in addition.

You can also install ``python-telegram-bot`` from source, though this is usually not necessary.
You can also install ``python-telegram-bot`` from source, though this is usually not necessary. Before building from source, check that Pything headers and a C compiler are installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTB is a pure-python package and doesn't have any C-bindings. What do you thnik Python headers & C compilers are required for?


.. code:: shell

Expand Down Expand Up @@ -166,8 +167,8 @@ To install multiple optional dependencies, separate them by commas, e.g. ``pip i

Additionally, two shortcuts are provided:

* ``pip install "python-telegram-bot[all]"`` installs all optional dependencies.
* ``pip install "python-telegram-bot[ext]"`` installs all optional dependencies that are related to ``telegram.ext``, i.e. ``[rate-limiter, webhooks, callback-data, job-queue]``.
* ``pip install -U "python-telegram-bot[all]"`` installs all optional dependencies.
* ``pip install -U "python-telegram-bot[ext]"`` installs all optional dependencies that are related to ``telegram.ext``, i.e. ``[rate-limiter, webhooks, callback-data, job-queue]``.
Comment on lines +170 to +171
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'd prefer not to have the upgrade option here. It's likely that people get to this section if they already have PTB installed but need an additional optional dependency. In that case, upgrading PTB might not actually be desired.


Working with PTB
----------------
Expand Down