fix socket recv error being silently ignored#195
Merged
code-of-kpp merged 1 commit intopython-smpplib:masterfrom Apr 15, 2022
Merged
fix socket recv error being silently ignored#195code-of-kpp merged 1 commit intopython-smpplib:masterfrom
code-of-kpp merged 1 commit intopython-smpplib:masterfrom
Conversation
Member
|
Thanks, @emnoor! I really admire this catch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python-smpplib/smpplib/client.py
Lines 259 to 260 in 4d74dc1
raw_pducan never be "falsy" as it was already tested above:python-smpplib/smpplib/client.py
Lines 241 to 242 in 4d74dc1
So this if-condition is never satisfied and the socket recv error is silently passed. It could potentially corrupt further recvs.