Skip to content

Restore previous behaviour of ignoring leading or trailing spaces when parsing unit strings #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apdavison merged 1 commit into from
Jan 14, 2026
Merged

Restore previous behaviour of ignoring leading or trailing spaces when parsing unit strings #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion quantities/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ def __init__(self):
def __getitem__(self, string):
# This approach to avoiding arbitrary evaluation of code is based on https://stackoverflow.com/a/11952618
# by https://stackoverflow.com/users/567292/ecatmur
tree = ast.parse(string, mode="eval")
stripped_string = string.strip() # discard leading or trailing spaces before parsing
tree = ast.parse(stripped_string, mode="eval")
valid = all(isinstance(node, self.whitelist) for node in ast.walk(tree))
if valid:
try:
Expand Down