Passed Exception message to the CashDrawerError class#268
Passed Exception message to the CashDrawerError class#268patkan merged 7 commits intopython-escpos:developmentfrom
Conversation
|
Hi @rakeshgunduka.
and for wrong number of args:
also for both wrong number of non int args:
|
|
Hi @belono , |
|
Hi @belono , |
|
Great! |
|
Yeah renamed the aliasing as 'err' which is short and descriptive. |
|
Looks great for me ;) |
|
Hi @rakeshgunduka thanks for the PR! |
|
Hi @belono , |
|
This test indicates that you have no test-coverage for this functionality. In order to get this away you could write a test, which provokes this error and then checks whether this exception gets raised. A test that does something similar is in https://github.com/python-escpos/python-escpos/blob/development/test/test_function_barcode.py#L35-L36 |
|
Hi @belono , |
|
I have added a little test to the PR. |
Contributor checklist
Description