This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Add node_meta to catalog/register endpoint #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome thanks @ibrahimmenem |
Collaborator
|
Thank you @ibrahimmenem. The PR is fine. One additional question. I it possible to update tests to cover node_meta parameter? They are missed also in original PR #190. |
Contributor
Author
|
@matusvalo sure! I can add a test to this PR. |
ibrahimmenem
force-pushed
the
add-node-meta-parameter
branch
from
5c0d772 to
23df603
Compare
Contributor
Author
|
@matusvalo Please check if it ok now! |
Collaborator
|
Thank you @ibrahimmenem ! Looks great. I have found out that one point is missing: https://www.consul.io/api/catalog.html#list-nodes-for-service Could you add also this endpoint to your PR to have catalog fully covered? Is it feasible to you? After this I will merge your PR. |
ibrahimmenem
force-pushed
the
add-node-meta-parameter
branch
from
c9a97d2 to
8753931
Compare
Collaborator
|
Thank you! Tomorrow I will merge the PR. |
GPF199541
pushed a commit
to GPF199541/python-consul
that referenced
this pull request
Mar 27, 2019
…ython-consul#222 did not fix this issue. Consul appears to want node_meta in the data body not params.
GPF199541
pushed a commit
to GPF199541/python-consul
that referenced
this pull request
May 8, 2019
…ython-consul#222 did not fix this issue. Consul appears to want node_meta in the data body not params. test add muil tags and from goconsulclient
mbrulatout
referenced
this pull request
in criteo/py-consul
Aug 28, 2023
Add node_meta to catalog/register endpoint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per request from #190 (comment)