fix: disable vcdiv64.asm on non-x86_64 Windows #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamesobutler
left a comment
jamesobutler
left a comment
There was a problem hiding this comment.
@bjia56 Do you need Windows on ARM testing in the CI? I see that there is now the windows-11-arm GitHub runner
This reverts commit ef78b77.
Contributor
Author
|
@jamesobutler It's a good idea, however I'm not too sure how to plug it into the existing GH runner setup. |
Contributor
|
Adding Windows 11 arm building would likely need to be restricted to the Python 3.11+ builds. It appears that the Python organization distributed Windows arm64 installers for Python 3.11.0 (https://www.python.org/downloads/release/python-3110/), but did not for earlier versions such as Python 3.10.7 (https://www.python.org/downloads/release/python-3107/). |
Contributor
Author
|
fwiw, I was able to get 3.9 and 3.10 builds when testing my portable fork here: bjia56/portable-python#129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for building on Windows arm64.
https://github.com/python/cpython/blob/3.12/PCbuild/_decimal.vcxproj#L140-L146