Skip to content

gh-145376: Fix various reference leaks#145377

Merged
encukou merged 1 commit intopython:mainfrom
JelleZijlstra:refcount-bugs
Mar 3, 2026
Merged

gh-145376: Fix various reference leaks#145377
encukou merged 1 commit intopython:mainfrom
JelleZijlstra:refcount-bugs

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Mar 1, 2026 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 1, 2026
Open
@JelleZijlstra JelleZijlstra added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 1, 2026
sobolevn
sobolevn reviewed Mar 1, 2026
View reviewed changes
@zware
Copy link
Member

zware commented Mar 1, 2026

Is there any improving the test suite to catch this kind of thing with the refleak bots? A quick glance suggests probably not, but it's worth at least getting a proper answer to the question written down :)

@JelleZijlstra
Copy link
Member Author

JelleZijlstra commented Mar 1, 2026

I think a few of these could be caught with a test, yes. It doesn't feel extremely high value (these particular paths aren't likely to regress), but I can add some if you like.

@zware
Copy link
Member

zware commented Mar 2, 2026

I'm in no position to make that value judgement :). More test coverage is generally better, but if they're not worth it they're not worth it.

@encukou encukou merged commit bd13cc0 into python:main Mar 3, 2026
57 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Mar 3, 2026

Thanks @JelleZijlstra for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Mar 3, 2026

Sorry, @JelleZijlstra and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bd13cc09faaef01635aea85130f33aa8cbb8b177 3.14

@miss-islington-app
Copy link

miss-islington-app bot commented Mar 3, 2026

Sorry, @JelleZijlstra and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bd13cc09faaef01635aea85130f33aa8cbb8b177 3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments

@sergey-miryanov sergey-miryanov sergey-miryanov approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

@encukou encukou

Labels

needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JelleZijlstra @zware @sergey-miryanov @sobolevn @kumaraditya303 @encukou