Skip to content

gh-69605: Hardcode some stdlib submodules in PyREPL module completion (os.path, collections.abc...) #138268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 6 commits into from
Sep 15, 2025
+80 −14
Merged

gh-69605: Hardcode some stdlib submodules in PyREPL module completion (os.path, collections.abc...) #138268

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc13676
PyREPL module completion: hardcode special stdlib submodules
loic-simon Aug 30, 2025
6f38649
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 30, 2025
362e821
Review feedback
loic-simon Aug 30, 2025
a952c2a
Use .extend instead of +
loic-simon Aug 30, 2025
fbfe884
Do not propose hardcoded submodules if local import
loic-simon Aug 31, 2025
985bb20
Nit nittety nit
ambv Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use .extend instead of +
  • Loading branch information
@loic-simon
loic-simon committed Aug 30, 2025
commit a952c2a6c8d589dd1e0af2cc11d3fecd001b807a
4 changes: 2 additions & 2 deletions Lib/_pyrepl/_module_completer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ def _find_modules(self, path: str, prefix: str) -> list[str]:
if mod_info.ispkg and mod_info.name == segment]
modules = self.iter_submodules(modules)

module_names = ([module.name for module in modules]
+ HARDCODED_SUBMODULES.get(path, []))
module_names = [module.name for module in modules]
module_names.extend(HARDCODED_SUBMODULES.get(path, ()))
return [module_name for module_name in module_names
if self.is_suggestion_match(module_name, prefix)]

Expand Down
Loading