Skip to content

gh-108494: Argument Clinic: inline parsing code for positional-only parameters in the limited C API #108622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 3 commits into from
Sep 3, 2023
Merged

gh-108494: Argument Clinic: inline parsing code for positional-only parameters in the limited C API #108622

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31238a6
gh-108494: Argument Clinic: inline parsing code in the limited C API
serhiy-storchaka Aug 28, 2023
9e5f3d2
Merge branch 'main' into clinic-limited-capi-inline
serhiy-storchaka Sep 3, 2023
b43b74c
Change TODO to NOTE.
serhiy-storchaka Sep 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change TODO to NOTE.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Sep 3, 2023
commit b43b74cec9015ae83efbb8792b4134649a834c3d
10 changes: 5 additions & 5 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3815,7 +3815,7 @@ def parse_arg(self, argname: str, displayname: str, *, limited_capi: bool) -> st
argname=argname)
if not limited_capi:
return super().parse_arg(argname, displayname, limited_capi=limited_capi)
# TODO: Raise ValueError for negative integer
# NOTE: Raises OverflowError for negative integer.
return self.format_code("""
{{{{
unsigned long uval = PyLong_AsUnsignedLong({argname});
Expand Down Expand Up @@ -3899,7 +3899,7 @@ def parse_arg(self, argname: str, displayname: str, *, limited_capi: bool) -> st
argname=argname)
if not limited_capi:
return super().parse_arg(argname, displayname, limited_capi=limited_capi)
# TODO: Raise ValueError for negative integer
# NOTE: Raises OverflowError for negative integer.
return self.format_code("""
{{{{
unsigned long uval = PyLong_AsUnsignedLong({argname});
Expand Down Expand Up @@ -3960,7 +3960,7 @@ def parse_arg(self, argname: str, displayname: str, *, limited_capi: bool) -> st
)
if not limited_capi:
return super().parse_arg(argname, displayname, limited_capi=limited_capi)
# TODO: Raise ValueError for negative integer
# NOTE: Raises OverflowError for negative integer.
return self.format_code("""
{paramname} = PyLong_AsUnsignedLong({argname});
if ({paramname} == (unsigned long)-1 && PyErr_Occurred()) {{{{
Expand Down Expand Up @@ -4013,7 +4013,7 @@ def parse_arg(self, argname: str, displayname: str, *, limited_capi: bool) -> st
)
if not limited_capi:
return super().parse_arg(argname, displayname, limited_capi=limited_capi)
# TODO: Raise ValueError for negative integer
# NOTE: Raises OverflowError for negative integer.
return self.format_code("""
{paramname} = PyLong_AsUnsignedLongLong({argname});
if ({paramname} == (unsigned long long)-1 && PyErr_Occurred()) {{{{
Expand Down Expand Up @@ -4152,7 +4152,7 @@ def parse_arg(self, argname: str, displayname: str, *, limited_capi: bool) -> st
argname=argname)
if not limited_capi:
return super().parse_arg(argname, displayname, limited_capi=limited_capi)
# TODO: Raise ValueError for negative integer
# NOTE: Raises OverflowError for negative integer.
return self.format_code("""
{paramname} = PyLong_AsSize_t({argname});
if ({paramname} == (size_t)-1 && PyErr_Occurred()) {{{{
Expand Down