Fix unused classes in a typing test #102437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephSBoyle
requested review from
AlexWaygood,
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
AlexWaygood
added
skip issue
skip news
🤖 automerge
needs backport to 3.10
Member
|
@JosephSBoyle, the same bug exists in the tests for Feel free to submit a PR to that repo as well :) |
Contributor
|
Status check is done, and it's a success ✅. |
Contributor
|
Thanks @JosephSBoyle for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-102441 is a backport of this pull request to the 3.11 branch. |
|
GH-102442 is a backport of this pull request to the 3.10 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of investigation issue #102433, I discovered what I believe to be an error where two classes
CIandDIare not being used. The assertions beneath them act onCandD, duplicating existing assertions in this test.Automerge-Triggered-By: GH:AlexWaygood