[truncate explanation] Fix edge case when we truncate due to max_chars #14105
+33
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
skip news
Previousely the added test case would output: "...Full output truncated (0 lines hidden), use '-vv' to show"
bluetech
reviewed
Jan 12, 2026
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Thanks! Please see my comments.
sum(len(x for s in strings) is consistentely faster than len(''.join(strings)), see https://claude.ai/public/artifacts/6a4c33e7-9ad5-4078-8ee7-e343984ce087
Pierre-Sassoulas
force-pushed
the
truncation-check
branch
from
159b275 to
49bb987
Compare
Member
Author
|
Drafting because I realized that there's a lot of optimization that can still be done. |
Better check the theory and the len of the string to know if we're going to truncate rather than checking the full length of the result after the fact.
bluetech
approved these changes
Jan 13, 2026
Member
bluetech
left a comment
bluetech
left a comment
There was a problem hiding this comment.
Thanks for splitting, looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previousely the added test case would output:
"...Full output truncated (0 lines hidden), use '-vv' to show"
Also removed some useless complexity.