chore(eslint): enable 3 rules of the unicorn plugin #2912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
the
chore
csouchet
changed the title
unicorn/prefer-at, unicorn/prefer-dom-node-dataset, unicorn/text-encoding-identifier-case rules
|
🎊 PR Preview 850f25a has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2912.surge.sh 🕐 Build time: 0.014s
🤖 By surge-preview |
|
♻️ PR Preview 850f25a has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
Kudos, SonarCloud Quality Gate passed! |
tbouffard
approved these changes
Oct 6, 2023
Member
tbouffard
left a comment
tbouffard
left a comment
There was a problem hiding this comment.
ℹ️ Please find a shorter name for this PR and its related commit.
Suggestion: "enable 3 rules of the unicorn plugin" and list them in the description
csouchet
changed the title
unicorn/prefer-at, unicorn/prefer-dom-node-dataset, unicorn/text-encoding-identifier-case rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add `unicorn/prefer-at`, `unicorn/prefer-dom-node-dataset`, `unicorn/text-encoding-identifier-case` rules.
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/text-encoding-identifier-case.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-dom-node-dataset.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-at.md
Covers #2742