refactor: introduce registry interfaces #2832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract interfaces to ensure that all methods are implemented in both BpmnElementsRegistry and the specific registries. This will also let reuse the method signatures in - CssRegistry - ElementsRegistry - OverlaysRegistry - StyleRegistry JSDoc add existing category to interfaces and make links in "see" directive works (at least in the HTML report produced by `typedoc`)
|
♻️ PR Preview 9d6c617 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 9d6c617 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
Kudos, SonarCloud Quality Gate passed! |
csouchet
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract interfaces to ensure that all methods are implemented in both
BpmnElementsRegistryand the specific registries. This will also let reuse the method signatures inCssClassesRegistryElementsRegistryOverlaysRegistryStyleRegistryAdd JSDoc existing category to interfaces and make links in "see" directive works (at least in the HTML report produced by
typedoc)closes #2803
covers #2813