chore(adapter-mssql): update mssql to v12.2.0 #28965
Conversation
Update @prisma/adapter-mssql to use mssql v12.2.0 instead of v11.0.1 Closes prisma#28944
|
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughUpdated the mssql package dependency in the MSSQL adapter from version ^11.0.1 to ^12.2.0 to use the latest version of the mssql library. Changes
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/adapter-mssql/package.json (1)
44-44: Update @types/mssql to match the runtime version.The
@types/mssqlpackage is at version 9.1.8 while the runtimemssqldependency is being updated to 12.2.0. This significant version gap creates type safety risks:
- Type definitions may not match the actual v12 API
- New features and changes in v12 won't be properly typed
- TypeScript won't catch potential runtime errors from API changes
Please verify the latest available version of
@types/mssqland update accordingly:#!/bin/bash # Description: Check latest version of @types/mssql on npm curl -s https://registry.npmjs.org/@types/mssql | jq '.["dist-tags"].latest, .versions | keys | .[-5:]'
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
packages/adapter-mssql/package.json
🔇 Additional comments (1)
packages/adapter-mssql/package.json (1)
40-40: Verify mssql v12 compatibility with integration tests.mssql v12 includes a breaking change: config objects are no longer cloned by the library and must not be mutated after being passed to the connection pool. The adapter implementation does not mutate the config after passing it to mssql, which is compatible with this change. However, run integration tests to confirm the upgrade works correctly with your SQL Server instances, especially around connection pooling and authentication flows.
|
@jacek-prisma would you like to give review |
4 participants
Update @prisma/adapter-mssql to use mssql v12.2.0 instead of v11.0.1
Closes #28944
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.