Improved pull request "Files Changed" experience feedback #163932
Replies: 2707 comments 1058 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Applying a suggestion from a comment when in "Files changed" view causes arrests the page with one of those "Are you sure you want to reload?" browser dialogues. |
Beta Was this translation helpful? Give feedback.
-
|
Does this have anything to do with adding ".patch" to the URL being broken now? It displays "This page isn’t working". |
Beta Was this translation helpful? Give feedback.
-
|
Please put back the |
Beta Was this translation helpful? Give feedback.
-
|
I made a suggestion that edited a few lines, but the apply button resulted in the lines being duplicated rather than edited: https://github.com/leanprover-community/mathlib4/pull/34526/changes#r2737217624 |
Beta Was this translation helpful? Give feedback.
-
|
Removing a blank file is not obvious. It states |
Beta Was this translation helpful? Give feedback.
-
|
Feature request: I would love reviewing large PRs more intellgently. Split the PR into different parts - show only changes related to renaming stuff. Then only changes related to moving code around. Then split the changes based on different unrelated parts changing. I want the ability to review and approve each of these splits independently. Also, for a large change, present the diffs in order that will make the reviewer understand it better |
Beta Was this translation helpful? Give feedback.
-
|
The submit button when leaving the review is so far down the page that it doesn't fit on the same page as the "review changes" button. |
Beta Was this translation helpful? Give feedback.
-
|
Commenting on multiple lines which are outside of a PR's change with an empty suggestion wrongly shows as just suggesting to remove 1 line (the bottom one), despite saying in the comment |
Beta Was this translation helpful? Give feedback.
-
|
Showing the subdirectories before the files is a total no-go: nested directory structures become impossible to see |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
I cant see over 300 files so I can't use it for the more sensitive PR's - also there is a bug when I sometimes can't approve PR in the new UI - the old one works better. |
Beta Was this translation helpful? Give feedback.
-
|
Consider the following sequence:
In this scenario, one cannot view the old comments attached to the outdated commits in their original context. |
Beta Was this translation helpful? Give feedback.
-
|
The comment sidebar does not restrict itself to the currently viewed commit, nor does it have a way to filter by commit that I could see. It would also be really nice if there were a way to check off files reviewed per-file-per-commit rather than just per-file. |
Beta Was this translation helpful? Give feedback.

















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions