fix(sandbox): restore docker.binds and preserve PATH in exec #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restore docker.binds field in zod-schema accidentally removed in 2563040 - Fix PATH preservation when running commands via docker exec (login shell sources /etc/profile which resets PATH; now prepends custom PATH) - Add unit tests for both fixes - Update docs with troubleshooting note for custom PATH in sandboxes Co-Authored-By: Claude Opus 4.5 <[email protected]>
steipete
added a commit
that referenced
this pull request
Jan 15, 2026
Thanks @akonyer. Co-authored-by: Aaron Konyer <[email protected]>
Contributor
|
Thanks @akonyer! Landed on main as eaace34. Changes:
Tests: pnpm lint (warns: restrict-template-expressions in src/infra/outbound/channel-selection.ts and src/gateway/server-methods/agent.ts), pnpm build, pnpm test |
steipete
added a commit
to mneves75/clawdbot
that referenced
this pull request
Jan 15, 2026
Thanks @akonyer. Co-authored-by: Aaron Konyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request restores and improves Docker sandbox configuration and command execution, focusing on two main areas: fixing configuration validation for custom bind mounts, and ensuring custom tools are accessible in the Docker sandbox by properly handling the
PATHenvironment variable. It also adds comprehensive tests for both features and updates documentation to help users troubleshoot common Docker sandbox issues.Sandbox Docker configuration fixes and enhancements:
docker.bindsconfig field in the sandbox configuration, fixing validation errors and allowing custom bind mounts to be specified again. Updated the schema and added tests to ensure only arrays of strings are accepted. [1] [2]docker.bindsand the fix for config validation errors with custom bind mounts.Docker exec command improvements:
buildDockerExecArgsinbash-tools.tsto prepend the configuredPATHafter login shell profile sourcing, ensuring both custom tools and system paths are available when running commands viadocker exec.buildDockerExecArgsto verify correctPATHhandling, shell invocation, and support for workdir and TTY options. [1] [2] [3]PATHfor custom tools in Docker sandboxes, including troubleshooting guidance for users.PATHwhen running commands viadocker exec.The bind mounts were accidentally removed I believe in this commit, so this is a bug fix/revert for: akonyer@2563040