Fix a few issues with type mappings for schema generator #6241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NinoFloris
approved these changes
Oct 8, 2025
vonzshik
added a commit
that referenced
this pull request
Oct 15, 2025
vonzshik
added a commit
that referenced
this pull request
Oct 15, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6240
So, there are two issues that are fixed.
The first one started to reproduce after #5123 and the gist of it is that while before we were consulting type mapping to deduce which actual type we're retrieving for schema, afterwards we stopped doing that. The fix seems to be quite easy, an additional
GetRepresentationalTypecall will unwrap all possible domains so we'll retrieve the original type.As for the second, this one is a bit weird. After #5559
NpgsqlDataReader.GetColumnSchemastarted to return the actual types for arrays (say,int[]or something similar) whileNpgsqlDataReader.GetFieldTypeis still returningArray(no idea why is that) and this mismatch resulted inNpgsqlDataAdapterbeing a bit confused because it can't mapArraytoint[](and that is becausetypeof(Array).IsArrayreturnsfalse, funny enough). As a fix I changed the way we retrieve the type by passingtypeof(object)(similar to how is done forGetFieldType).@NinoFloris you probably should also take a look.