Skip to content

Conversation

@roji
Copy link
Member

@roji roji commented Jul 6, 2025

No description provided.

@roji roji requested a review from vonzshik as a code owner July 6, 2025 08:30
@roji
Copy link
Member Author

roji commented Jul 6, 2025

@Brar note the test failures when running the replication tests against PG18 beta1... I suspect it might just be test issues (where we assume a very specific message order which changed), but who knows...

I propose we merge this for now without adding PG18 as a mandatory passing CI config, and get it green afterwards...

@Brar
Copy link
Member

Brar commented Jul 6, 2025

Most of the errors are related to transaction streaming.
The assertions fail because transaction streaming doesn't happen although it should.
It's probably related to logical_decoding_work_mem configuration or something around this.

@Brar
Copy link
Member

Brar commented Jul 6, 2025

It's probably related to logical_decoding_work_mem configuration or something around this.

I just saw that it's only happening in the LogicalDecodingMessage() test, so streaming generally seems to work but not for logical decoding messages.
That's surprising.
Maybe a bug in the PG beta?
Unfortunately I don't have much time to investigate this at the moment.

@roji
Copy link
Member Author

roji commented Jul 7, 2025

Sure thing - I opened #6158 to track this. I don't think it's super urgent, though especially if there may be a problem on the PG18 we'd want to report that.

@vonzshik @NinoFloris i propose just merging this PR as-is, with the failing PG18 config. It doesn't block us from merging PRs (I haven't added PG18 as a mandatory check), and this way we'll get a constant reminder too ;)

Copy link
Contributor

@vonzshik vonzshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm OK with merging this as is for now.

@roji roji merged commit be916c2 into npgsql:main Jul 7, 2025
15 of 16 checks passed
@roji roji deleted the PG18 branch July 7, 2025 10:50
This was referenced Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants