-
Notifications
You must be signed in to change notification settings - Fork 874
Do CI testing for PG18 (beta) #6155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Brar note the test failures when running the replication tests against PG18 beta1... I suspect it might just be test issues (where we assume a very specific message order which changed), but who knows... I propose we merge this for now without adding PG18 as a mandatory passing CI config, and get it green afterwards... |
|
Most of the errors are related to transaction streaming. |
I just saw that it's only happening in the LogicalDecodingMessage() test, so streaming generally seems to work but not for logical decoding messages. |
|
Sure thing - I opened #6158 to track this. I don't think it's super urgent, though especially if there may be a problem on the PG18 we'd want to report that. @vonzshik @NinoFloris i propose just merging this PR as-is, with the failing PG18 config. It doesn't block us from merging PRs (I haven't added PG18 as a mandatory check), and this way we'll get a constant reminder too ;) |
vonzshik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm OK with merging this as is for now.
No description provided.