Skip to content

parameter-collection Clone() should set correct collection instance #6066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NinoFloris merged 1 commit into from
Mar 22, 2025
Merged

parameter-collection Clone() should set correct collection instance #6066

NinoFloris merged 1 commit into from
Mar 22, 2025

Conversation

@mgravell
Copy link
Contributor

@mgravell mgravell commented Mar 21, 2025

fix #6065

@mgravell mgravell requested review from roji and vonzshik as code owners March 21, 2025 11:09
@mgravell mgravell mentioned this pull request Mar 21, 2025
Closed
@mgravell
Copy link
Contributor Author

mgravell commented Mar 22, 2025

Test failures look like unrelated CI problems on macos

NinoFloris
NinoFloris approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@NinoFloris NinoFloris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, that's a 10 year old bug...

LGTM!

CI failures are fixed by #6071

@NinoFloris NinoFloris merged commit e8ce19f into npgsql:main Mar 22, 2025
22 of 24 checks passed
vonzshik pushed a commit that referenced this pull request Mar 24, 2025
@mgravell @vonzshik
NpgsqlParameterCollection.Clone() should set correct collection insta…
900e9be 
…nce (#6066)

fix #6065

(cherry picked from commit e8ce19f)
vonzshik pushed a commit that referenced this pull request Mar 24, 2025
@mgravell @vonzshik
NpgsqlParameterCollection.Clone() should set correct collection insta…
8fd4b43 
…nce (#6066)

fix #6065

(cherry picked from commit e8ce19f)
@vonzshik
Copy link
Contributor

vonzshik commented Mar 24, 2025

Backported to 9.0.4 via 900e9be, 8.0.8 via 8fd4b43

This was referenced Nov 23, 2025
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
This was referenced Dec 22, 2025
Closed
Open
Merged
Open
Open
Closed
Closed
This was referenced Dec 29, 2025
Merged
Open
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 6, 2026
Open
Closed
Open
This was referenced Jan 19, 2026
Closed
Open
Open
Open
Open
This was referenced Jan 30, 2026
Open
Closed
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NinoFloris NinoFloris NinoFloris approved these changes

@roji roji Awaiting requested review from roji roji is a code owner

@vonzshik vonzshik Awaiting requested review from vonzshik vonzshik is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: command Clone() specifies incorrect parameter collection

3 participants

@mgravell @vonzshik @NinoFloris