tools: remove custom logic for skipping test-strace-openat-openssl#62038
Merged
aduh95 merged 1 commit intonodejs:mainfrom Mar 2, 2026
Merged
tools: remove custom logic for skipping test-strace-openat-openssl#62038aduh95 merged 1 commit intonodejs:mainfrom
test-strace-openat-openssl#62038aduh95 merged 1 commit intonodejs:mainfrom
Conversation
aduh95
added
dont-land-on-v20.x
richardlau
approved these changes
Feb 28, 2026
aduh95
added
the
author ready
cjihrig
approved these changes
Feb 28, 2026
aduh95
added
the
commit-queue
lpinca
approved these changes
Feb 28, 2026
aduh95
force-pushed
the
test-strace-openat-openssl
branch
from
1384e59 to
97c6e3d
Compare
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62038 ✔ Done loading data for nodejs/node/pull/62038 ----------------------------------- PR info ------------------------------------ Title tools: remove custom logic for skipping `test-strace-openat-openssl` (#62038) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:test-strace-openat-openssl -> nodejs:main Labels author ready, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x Commits 1 - tools: remove custom logic for skipping `test-strace-openat-openssl` Committers 1 - Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/62038 Refs: https://github.com/nodejs/node/pull/61987 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62038 Refs: https://github.com/nodejs/node/pull/61987 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - tools: remove custom logic for skipping `test-strace-openat-openssl` ℹ This PR was created on Sat, 28 Feb 2026 08:08:55 GMT ✔ Approvals: 4 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/62038#pullrequestreview-3870462136 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/62038#pullrequestreview-3870523009 ✔ - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/62038#pullrequestreview-3870529022 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62038#pullrequestreview-3870829468 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/22567442800 |
Contributor
Author
|
Landed in 97c1312 |
richardlau
pushed a commit
that referenced
this pull request
Mar 2, 2026
PR-URL: #62038 Refs: #61987 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gürgün Dayıoğlu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #61987