[v18.x backport] build: update gcovr to 7.2 and codecov config#57565
Closed
richardlau wants to merge 1 commit intov18.x-stagingfrom
Closed
[v18.x backport] build: update gcovr to 7.2 and codecov config#57565richardlau wants to merge 1 commit intov18.x-stagingfrom
richardlau wants to merge 1 commit intov18.x-stagingfrom
Conversation
PR-URL: #54019 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
richardlau
added
the
fast-track
Contributor
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
Member
Author
|
cc @nodejs/releasers It looks like this fixes the failing coverage builds on v18.x-staging (see #57557). Requesting fast track so I can include it in the Node.js 18 I am preparing, or we can decide not to fix it this close to Node.js 18's End-of-Life. |
github-actions
bot
removed
the
request-ci
Collaborator
targos
approved these changes
Mar 20, 2025
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
BridgeAR
approved these changes
Mar 21, 2025
Collaborator
Collaborator
Collaborator
richardlau
pushed a commit
that referenced
this pull request
Mar 26, 2025
PR-URL: #54019 Backport-PR-URL: #57565 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Member
Author
|
Landed in fce923b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #54019
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: James M Snell [email protected]
Reviewed-By: Michaël Zasso [email protected]
Opening to see if backporting this fixes the coverage workflows for
v18.x-staging.