Skip to content

meta: remove build-windows.yml#54662

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
avivkeller:patch-117
Sep 18, 2024
Merged

meta: remove build-windows.yml#54662
nodejs-github-bot merged 1 commit intonodejs:mainfrom
avivkeller:patch-117

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Aug 30, 2024

All the actions done in build-windows.yml are also done in coverage-windows.yml, this means that the separate building of windows in this action is redundant.

node/.github/workflows/coverage-windows.yml

Lines 46 to 58 in 2bfc9e4

- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
run: choco install nasm
- name: Environment Information
run: npx envinfo
- name: Build
run: ./vcbuild.bat

is the same as

node/.github/workflows/build-windows.yml

Lines 41 to 53 in 2bfc9e4

- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
run: choco install nasm
- name: Environment Information
run: npx envinfo
- name: Build
run: ./vcbuild.bat

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 30, 2024

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 30, 2024
@avivkeller
Copy link
Member Author

avivkeller commented Aug 30, 2024

CC @nodejs/platform-windows

@avivkeller avivkeller added the windows Issues and PRs related to the Windows platform. label Sep 7, 2024
@avivkeller
Copy link
Member Author

avivkeller commented Sep 17, 2024

Is this good to land?

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 18, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 18, 2024

Commit Queue failed
- Loading data for nodejs/node/pull/54662
✔  Done loading data for nodejs/node/pull/54662
----------------------------------- PR info ------------------------------------
Title      meta: remove `build-windows.yml` (#54662)
Author     Aviv Keller <[email protected]> (@RedYetiDev)
Branch     RedYetiDev:patch-117 -> nodejs:main
Labels     windows, meta
Commits    1
 - meta: remove `build-windows.yml`
Committers 1
 - RedYetiDev <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54662
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54662
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - meta: remove `build-windows.yml`
   ℹ  This PR was created on Fri, 30 Aug 2024 15:55:41 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54662#pullrequestreview-2274122543
   ✔  - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/54662#pullrequestreview-2289493802
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10917631736

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2024
@nodejs-github-bot nodejs-github-bot merged commit ccc7ce0 into nodejs:main Sep 18, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 18, 2024

Landed in ccc7ce0

targos pushed a commit that referenced this pull request Oct 4, 2024
@avivkeller @targos
meta: remove build-windows.yml
ce0d0c1 
PR-URL: #54662
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@avivkeller @louwers
meta: remove build-windows.yml
71385da 
PR-URL: nodejs#54662
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
@richardlau richardlau mentioned this pull request Nov 20, 2024
Closed
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@avivkeller @tpoisseau
meta: remove build-windows.yml
122755b 
PR-URL: nodejs#54662
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito added lts-watch-v20.x PRs that may need to be released in v20.x and removed dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Jun 10, 2025